mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 61272: Added a MockResourceProvider.
Date Wed, 02 Aug 2017 11:49:04 GMT


> On Aug. 2, 2017, 12:40 a.m., Jie Yu wrote:
> > src/tests/mesos.hpp
> > Lines 2255 (patched)
> > <https://reviews.apache.org/r/61272/diff/2/?file=1786382#file1786382line2255>
> >
> >     I don't think we need a v0 MockResourceProvider. Let's just use v1

This isn't a v0 MockResouceProvider, but a template that is (at the moment) only used for
v1, but could be reused for v2...
This is a common pattern in `mesos.hpp` introduced by `MockHTTPScheduler` and `MockHTTPExecutor`
that I'm following here.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61272/#review181923
-----------------------------------------------------------


On Aug. 2, 2017, 1:38 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61272/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 1:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7469
>     https://issues.apache.org/jira/browse/MESOS-7469
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a MockResourceProvider.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 6f06261d81870b923b7053daf8205327c4ac6a45 
> 
> 
> Diff: https://reviews.apache.org/r/61272/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message