mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 61298: Replaced `include_directories()` for `mesos-protobufs`.
Date Wed, 02 Aug 2017 00:55:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61298/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

The `include_directories()` CMake command should never be used as it has
global side effects, and is superfluous when the CMake dependency graph
is used correctly.


Diffs
-----

  src/CMakeLists.txt 98ccaf41bf5e7d14164e1c8b6e49268ac865a52c 


Diff: https://reviews.apache.org/r/61298/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message