mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 61182: Sent a resource provider message when providers subscribe.
Date Tue, 01 Aug 2017 17:42:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61182/
-----------------------------------------------------------

(Updated Aug. 1, 2017, 7:42 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
-------

Used a single file for RP manager-related tests; used `MockResourceProvider`; rebased.


Bugs: MESOS-7837
    https://issues.apache.org/jira/browse/MESOS-7837


Repository: mesos


Description
-------

In order to inform users of resource provider managers that the
managed resources have changed, we add a new 'ResourceProviderMessage'
type for communicating changes to the managed total resources.

We add code to trigger sending of that message when a resource
provider subscribes with the manager.

In the future this message could also be used to communicate changes
to an already subscribed resource provider's total resources.


Diffs (updated)
-----

  src/resource_provider/manager.cpp 44e1576d4462295d404429d51682134306047462 
  src/resource_provider/message.hpp 916926bf278de9ed919384a82a452d3ced06bd04 
  src/tests/resource_provider_manager_tests.cpp 85906ea5e1bb3516ef264de22913ce0a3c9c58c5 


Diff: https://reviews.apache.org/r/61182/diff/3/

Changes: https://reviews.apache.org/r/61182/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message