| Jie Yu |
Re: Review Request 60729: Fixed persistent volume and host volume conflict issue. |
Mon, 10 Jul, 18:14 |
| Jie Yu |
Re: Review Request 60750: Added unit tests for persistent volume and host volume conflict issue. |
Mon, 10 Jul, 18:30 |
| Jie Yu |
Re: Review Request 60750: Added unit tests for persistent volume and host volume conflict issue. |
Tue, 11 Jul, 16:26 |
| Jie Yu |
Re: Review Request 60768: Added resource provider ID to calls. |
Tue, 11 Jul, 17:19 |
| Jie Yu |
Re: Review Request 60769: Added evolve functions for resource provider Event/Call. |
Tue, 11 Jul, 17:21 |
| Jie Yu |
Re: Review Request 60500: Introduced `--default_container_dns` agent flag. |
Fri, 14 Jul, 18:31 |
| Jie Yu |
Re: Review Request 60879: Preventing agent recovery failing from unsuccessful `docker rm`. |
Fri, 14 Jul, 20:49 |
| Jie Yu |
Re: Review Request 60888: WIP: Added recovery logic for standalone containers. |
Mon, 17 Jul, 17:12 |
| Jie Yu |
Re: Review Request 60888: WIP: Added recovery logic for standalone containers. |
Mon, 17 Jul, 18:54 |
| Jie Yu |
Re: Review Request 60500: Introduced `--default_container_dns` agent flag. |
Mon, 17 Jul, 19:01 |
| Jie Yu |
Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager. |
Mon, 17 Jul, 21:50 |
| Jie Yu |
Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager. |
Mon, 17 Jul, 21:51 |
| Jie Yu |
Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager. |
Mon, 17 Jul, 22:31 |
| Jie Yu |
Re: Review Request 60887: Decoupling `Docker::rm` from `Docker::stop` in agent recovery. |
Tue, 18 Jul, 00:00 |
| Jie Yu |
Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo. |
Wed, 19 Jul, 19:02 |
| Jie Yu |
Re: Review Request 60984: Set the `LIBPROCESS_IP` env variable before starting the fetcher. |
Wed, 19 Jul, 21:07 |
| Jie Yu |
Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo. |
Fri, 21 Jul, 21:15 |
| Jie Yu |
Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo. |
Fri, 21 Jul, 21:16 |
| Jie Yu |
Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo. |
Fri, 21 Jul, 23:33 |
| Jie Yu |
Re: Review Request 61081: Considered ResourceProvider 'name' and 'type' in equality checks. |
Mon, 24 Jul, 16:34 |
| Jie Yu |
Re: Review Request 61082: Removed tracking ResourceProvider total resources in its info. |
Mon, 24 Jul, 16:38 |
| Jie Yu |
Re: Review Request 60500: Introduced `--default_container_dns` agent flag. |
Mon, 24 Jul, 17:46 |
| Jie Yu |
Re: Review Request 61120: Fixed the sandbox_path volume source path ownership. |
Tue, 25 Jul, 23:25 |
| Jie Yu |
Re: Review Request 61122: Fixed the host volume relative host path ownership. |
Tue, 25 Jul, 23:26 |
| Jie Yu |
Re: Review Request 61097: Added gRPC support in libprocess. |
Wed, 26 Jul, 22:48 |
| Jie Yu |
Re: Review Request 60770: Added validation functions for resource provider calls. |
Wed, 26 Jul, 23:46 |
| Jie Yu |
Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager. |
Thu, 27 Jul, 00:15 |
| Jie Yu |
Re: Review Request 61097: Added gRPC support in libprocess. |
Fri, 28 Jul, 19:09 |
| Jie Yu |
Re: Review Request 61097: Added gRPC support in libprocess. |
Fri, 28 Jul, 19:21 |
| Jie Yu |
Re: Review Request 61098: Added unit tests for gRPC support in libprocess. |
Fri, 28 Jul, 19:57 |
| Jie Yu |
Re: Review Request 61097: Added gRPC support in libprocess. |
Fri, 28 Jul, 21:02 |
| Jie Yu |
Re: Review Request 61179: Added 'devolve' overload for 'ResourceProviderID'. |
Fri, 28 Jul, 21:14 |
| Jie Yu |
Re: Review Request 61180: Added a resource providers total resources to the subscribe call. |
Fri, 28 Jul, 21:36 |
| Jie Yu |
Re: Review Request 61181: Stored subscribed resources in resource provider manager. |
Fri, 28 Jul, 21:42 |
| Jie Yu |
Re: Review Request 61182: Sent a resource provider message when providers subscribe. |
Fri, 28 Jul, 22:03 |
| Jie Yu |
Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates. |
Fri, 28 Jul, 22:20 |
| Jie Yu |
Re: Review Request 61180: Added a resource providers total resources to the subscribe call. |
Mon, 31 Jul, 21:20 |
| Jie Yu |
Re: Review Request 61182: Sent a resource provider message when providers subscribe. |
Mon, 31 Jul, 21:53 |
| Joseph Wu |
Re: Review Request 60292: Windows: Added a `wstring wide_stringify(string)` helper. |
Mon, 10 Jul, 23:16 |
| Joseph Wu |
Re: Review Request 60293: Windows: Switched from `gethostname` to `GetComputerName`. |
Mon, 10 Jul, 23:19 |
| Joseph Wu |
Re: Review Request 60294: Windows: Added `os::LONGPATH_PREFIX` constant. |
Mon, 10 Jul, 23:19 |
| Joseph Wu |
Re: Review Request 60296: Windows: Added long path test. |
Mon, 10 Jul, 23:41 |
| Joseph Wu |
Re: Review Request 60299: Windows: Fixed `os::exists()` to support long paths. |
Mon, 10 Jul, 23:43 |
| Joseph Wu |
Re: Review Request 60300: Windows: Fixed `isdir()` and `isfile()` to support long paths. |
Mon, 10 Jul, 23:43 |
| Joseph Wu |
Re: Review Request 60305: Windows: Refactored `reparse_point_attribute_set()`. |
Mon, 10 Jul, 23:47 |
| Joseph Wu |
Re: Review Request 60307: Windows: Fixed `CreateSymbolicLink()` to support long paths. |
Mon, 10 Jul, 23:48 |
| Joseph Wu |
Re: Review Request 60308: Refactored `enum FollowSymlink` to an `enum class FollowSymlink`. |
Mon, 10 Jul, 23:48 |
| Joseph Wu |
Re: Review Request 60310: Fixed fetcher to use `enum class FollowSymlink`. |
Mon, 10 Jul, 23:51 |
| Joseph Wu |
Re: Review Request 60311: Windows: Replaced use of `_stat()` with `os::stat::isdir()`. |
Mon, 10 Jul, 23:53 |
| Joseph Wu |
Re: Review Request 60313: Windows: Fixed `os::rm()` to support long paths. |
Mon, 10 Jul, 23:55 |
| Joseph Wu |
Re: Review Request 60314: Windows: Fixed `os::rmdir()` to support long paths. |
Mon, 10 Jul, 23:58 |
| Joseph Wu |
Re: Review Request 60315: Windows: Fixed `os::open()` to support long paths. |
Mon, 10 Jul, 23:58 |
| Joseph Wu |
Re: Review Request 60317: Windows: Fixed `os::access()` to support long paths. |
Tue, 11 Jul, 00:07 |
| Joseph Wu |
Re: Review Request 60318: Windows: Made `os::temp()` use UTF-16 system calls. |
Tue, 11 Jul, 00:07 |
| Joseph Wu |
Re: Review Request 60320: Windows: Cleaned up `os::var()`. |
Tue, 11 Jul, 00:07 |
| Joseph Wu |
Re: Review Request 60321: Windows: Fixed `fs::list()` to support long paths. |
Tue, 11 Jul, 00:07 |
| Joseph Wu |
Re: Review Request 60322: Windows: Fixed `os::rename()` to support long paths. |
Tue, 11 Jul, 00:12 |
| Joseph Wu |
Re: Review Request 60323: Windows: Fixed `process::createIoPath()` to support long paths. |
Tue, 11 Jul, 00:14 |
| Joseph Wu |
Re: Review Request 60324: Windows: Implemented `WSTRINGIFY()` to print exit codes. |
Tue, 11 Jul, 00:14 |
| Joseph Wu |
Re: Review Request 60325: Windows: Replaced `ping` with `Start-Sleep`. |
Tue, 11 Jul, 00:14 |
| Joseph Wu |
Re: Review Request 60326: Added `vector<string>` explicit cast to `Argv`. |
Tue, 11 Jul, 00:16 |
| Joseph Wu |
Re: Review Request 60327: Added `map<string, string>` explict cast to `Envp`. |
Tue, 11 Jul, 00:16 |
| Joseph Wu |
Re: Review Request 60328: Windows: Added `create_process()` wrapper to `shell.hpp`. |
Tue, 11 Jul, 00:16 |
| Joseph Wu |
Re: Review Request 60329: Windows: Replaced `CreateProcess()` with `create_process()` helper. |
Tue, 11 Jul, 00:16 |
| Joseph Wu |
Re: Review Request 60330: Windows: Fixed use of `get_system_env()` in containerizer. |
Tue, 11 Jul, 00:16 |
| Joseph Wu |
Re: Review Request 60331: Windows: Disable code using `os::shell()`. |
Tue, 11 Jul, 00:16 |
| Joseph Wu |
Re: Review Request 60332: Windows: Fixed `fs::usage()` to support long paths. |
Tue, 11 Jul, 00:16 |
| Joseph Wu |
Re: Review Request 60334: Windows: Made `WindowsError` use Unicode. |
Tue, 11 Jul, 00:17 |
| Joseph Wu |
Re: Review Request 60335: Windows: Made `net.hpp` use Unicode. |
Tue, 11 Jul, 00:17 |
| Joseph Wu |
Re: Review Request 60336: Windows: Made environment abstractions use Unicode. |
Tue, 11 Jul, 00:17 |
| Joseph Wu |
Re: Review Request 60337: Windows: Made `os::user()` use Unicode. |
Tue, 11 Jul, 00:17 |
| Joseph Wu |
Re: Review Request 60338: Windows: Made `dynamiclibrary.hpp` use Unicode. |
Tue, 11 Jul, 00:17 |
| Joseph Wu |
Re: Review Request 60339: Windows: Deleted `os::hstrerror()` as it is unused. |
Tue, 11 Jul, 00:17 |
| Joseph Wu |
Re: Review Request 60340: Windows: Made job object APIs use Unicode. |
Tue, 11 Jul, 00:18 |
| Joseph Wu |
Re: Review Request 60341: Windows: Changed job object names to `wstring`. |
Tue, 11 Jul, 00:18 |
| Joseph Wu |
Re: Review Request 60342: Windows: Made version info use Unicode. |
Tue, 11 Jul, 00:18 |
| Joseph Wu |
Re: Review Request 60343: Windows: Made `process_entry()` use Unicode. |
Tue, 11 Jul, 00:18 |
| Joseph Wu |
Re: Review Request 60344: Windows: Require building with `_UNICODE` and `UNICODE`. |
Tue, 11 Jul, 00:18 |
| Joseph Wu |
Re: Review Request 60345: Windows: Set Unicode compilation flags. |
Tue, 11 Jul, 00:18 |
| Joseph Wu |
Re: Review Request 60758: Windows: Updated documentation for NTFS long path support. |
Tue, 11 Jul, 01:38 |
| Joseph Wu |
Re: Review Request 60758: Windows: Updated documentation for NTFS long path support. |
Tue, 11 Jul, 01:56 |
| Joseph Wu |
Re: Review Request 60788: Windows: Fixed long path support in `reparsepoint.hpp`. |
Fri, 14 Jul, 17:43 |
| Joseph Wu |
Re: Review Request 60821: Introduced a "no sender" UPID. |
Fri, 14 Jul, 22:33 |
| Joseph Wu |
Review Request 60888: WIP: Added recovery logic for standalone containers. |
Sat, 15 Jul, 00:41 |
| Joseph Wu |
Review Request 60889: WIP: Added tests for launching standalone containers. |
Sat, 15 Jul, 00:41 |
| Joseph Wu |
Review Request 60890: WIP: Defined API for launching standalone containers. |
Sat, 15 Jul, 00:41 |
| Joseph Wu |
Review Request 60891: WIP: Implemented agent API for launching standalone containers. |
Sat, 15 Jul, 00:41 |
| Joseph Wu |
Re: Review Request 60892: Fixed the hard-coded forward slash which breaks windows docker container task launching in DC/OS path |
Sat, 15 Jul, 01:22 |
| Joseph Wu |
Re: Review Request 60482: Defined Git variables in CMake configure file. |
Mon, 17 Jul, 17:18 |
| Joseph Wu |
Re: Review Request 60888: WIP: Added recovery logic for standalone containers. |
Mon, 17 Jul, 17:35 |
| Joseph Wu |
Re: Review Request 60791: Add fetcher cache space usage metrics. |
Mon, 17 Jul, 17:55 |
| Joseph Wu |
Re: Review Request 60888: WIP: Added recovery logic for standalone containers. |
Mon, 17 Jul, 21:28 |
| Joseph Wu |
Re: Review Request 60233: Linted support/post-reviews.py. |
Mon, 17 Jul, 22:05 |
| Joseph Wu |
Re: Review Request 60234: Linted support/push-commits.py. |
Mon, 17 Jul, 22:05 |
| Joseph Wu |
Re: Review Request 60235: Linted support/test-upgrade.py. |
Mon, 17 Jul, 23:30 |
| Joseph Wu |
Re: Review Request 60236: Linted support/verify-reviews.py. |
Tue, 18 Jul, 00:09 |
| Joseph Wu |
Re: Review Request 60890: WIP: Defined API for launching standalone containers. |
Tue, 18 Jul, 00:12 |
| Joseph Wu |
Re: Review Request 60917: Used a real UPID to send `LearnedMessage`. |
Tue, 18 Jul, 00:37 |
| Joseph Wu |
Re: Review Request 61093: Windows: Disabled permissive building. |
Mon, 24 Jul, 23:30 |
| Joseph Wu |
Re: Review Request 61094: Multi-role: Adjusted `long-lived-framework` to use allocated resources. |
Mon, 24 Jul, 23:49 |