mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Haijiang Chen <chjhaiji...@gmail.com>
Subject Re: Review Request 60758: Windows: Updated documentation for NTFS long path support.
Date Tue, 11 Jul 2017 05:31:59 GMT
OK, Thanks Andy. I think I find it from latest source code in github.

-Haijiang
> On 11 Jul 2017, at 11:38 AM, Andrew Schwartzmeyer <andrew@schwartzmeyer.com> wrote:
> 
> It is all the patches in the series that this patch ended. The start of the chain is
here: https://reviews.apache.org/r/60292/ <https://reviews.apache.org/r/60292/>
> Thanks for the interest! It was quite the undertaking to fix this up.
> 
> Cheers,
> 
> Andy
> 
> 
> On Mon, Jul 10, 2017, 8:32 PM Haijiang Chen <chjhaijiang@gmail.com <mailto:chjhaijiang@gmail.com>>
wrote:
> Thanks.
> Can you please help to point out which ticket that fixed it? I am interested with code
changes as well.
> 
> Regards,
> Haijiang
> 
>> On 11 Jul 2017, at 9:21 AM, Andrew Schwartzmeyer <andrew@schwartzmeyer.com <mailto:andrew@schwartzmeyer.com>>
wrote:
>> 
>> It means that it is fixed for Mesos entirely, in code. I rewrote all our use of the
Windows APIs to use the Unicode and long path supporting versions exclusively, with a long
path helper to pass the correctly formatted paths to the APIs.
>> 
>> The only caveat is that tasks which do not support long paths need to have the agent
use a short working directory so that the task is run in a short path. But all the Mesos code
itself now supports long  paths automatically, with zero system configuration :)
>> 
>> 
>> On Mon, Jul 10, 2017, 6:07 PM Haijiang Chen <chjhaijiang@gmail.com <mailto:chjhaijiang@gmail.com>>
wrote:
>> Does it mean that the Windows Long path will be fixed somewhere in the installation?
>> 
>> Thanks,
>> Haijiang
>> > On 11 Jul 2017, at 8:51 AM, Andrew Schwartzmeyer <andrew@schwartzmeyer.com
<mailto:andrew@schwartzmeyer.com>> wrote:
>> >
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/60758/ <https://reviews.apache.org/r/60758/>
>> > -----------------------------------------------------------
>> >
>> > Review request for mesos, Joseph Wu and Li Li.
>> >
>> >
>> > Repository: mesos
>> >
>> >
>> > Description
>> > -------
>> >
>> > The list of individual components was also removed for clarity.
>> > Developers should either install the entire workload (which is confirmed
>> > sufficient), or know their environment well enough to choose specific
>> > components. Furthermore, the list of available components changes
>> > frequently enough that maintaining this list becomes difficult.
>> >
>> >
>> > Diffs
>> > -----
>> >
>> >  docs/windows.md <http://windows.md/> d596158b1f5dadddcf28a8675f260924caf33547
>> >
>> >
>> > Diff: https://reviews.apache.org/r/60758/diff/1/ <https://reviews.apache.org/r/60758/diff/1/>
>> >
>> >
>> > Testing
>> > -------
>> >
>> >
>> > Thanks,
>> >
>> > Andrew Schwartzmeyer
>> >
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message