mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 60991: Changed Device::path to optional and introduced Device::Number.
Date Mon, 31 Jul 2017 16:54:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60991/#review181814
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On July 26, 2017, 1:01 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60991/
> -----------------------------------------------------------
> 
> (Updated July 26, 2017, 1:01 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhongbo
Tian.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A device in cgroup can be represented as either a path or a major:minor
> number. Need to change the `required` Device::path to `optional` to
> add Number in the device protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8f8079bd7c2de4e8b2f8f9a56e2731b77b8e1575 
>   include/mesos/v1/mesos.proto 720f307f8d738b0787e7c47be7ee15be38b2c0d0 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp ddf2a4d661001a3a5832c21504420223ca60a753

> 
> 
> Diff: https://reviews.apache.org/r/60991/diff/2/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message