mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.
Date Mon, 31 Jul 2017 16:53:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60932/#review181813
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto
Line 2918 (original), 2918 (patched)
<https://reviews.apache.org/r/60932/#comment257569>

    Does this comment need updating now?



include/mesos/v1/mesos.proto
Line 2901 (original), 2901 (patched)
<https://reviews.apache.org/r/60932/#comment257571>

    Does this comment need updating now?


- James Peach


On July 29, 2017, 11:58 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60932/
> -----------------------------------------------------------
> 
> (Updated July 29, 2017, 11:58 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-6162
>     https://issues.apache.org/jira/browse/MESOS-6162
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only statistics information for blkio in protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 41e42b4996235cbee26f580f4a7aa2daed166b7f 
>   include/mesos/v1/mesos.proto 9de282f85b8d0ba91fa3de85acd5d0f4082a47d8 
> 
> 
> Diff: https://reviews.apache.org/r/60932/diff/6/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message