mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61112: Added uris flag to balloon framework.
Date Mon, 31 Jul 2017 13:27:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61112/#review181799
-----------------------------------------------------------




src/examples/balloon_framework.cpp
Lines 20 (patched)
<https://reviews.apache.org/r/61112/#comment257552>

    Do you still need this?



src/examples/balloon_framework.cpp
Lines 26 (patched)
<https://reviews.apache.org/r/61112/#comment257553>

    Why do you need this one?



src/examples/balloon_framework.cpp
Lines 55 (patched)
<https://reviews.apache.org/r/61112/#comment257554>

    Don't need this anymore?



src/examples/balloon_framework.cpp
Lines 127 (patched)
<https://reviews.apache.org/r/61112/#comment257548>

    Let's call it `--executor_uris` for calrity.



src/examples/balloon_framework.cpp
Lines 132 (patched)
<https://reviews.apache.org/r/61112/#comment257555>

    s\URI\CommandInfo::URI because `URI` is not a top level message.



src/examples/balloon_framework.cpp
Lines 498-504 (original), 529-551 (patched)
<https://reviews.apache.org/r/61112/#comment257549>

    I'd suggest to use either `--executor_uri` or new `--uris` flag. Let's update comments
for both flags to mention this, add a `CHECK` above that only a single one is set, and leave
a deprecation `TODO` for the former flag.



src/examples/balloon_framework.cpp
Lines 540 (patched)
<https://reviews.apache.org/r/61112/#comment257550>

    Indent is off.



src/examples/balloon_framework.cpp
Lines 543-545 (patched)
<https://reviews.apache.org/r/61112/#comment257556>

    `EXIT(EXIT_FAILURE)` instead?



src/examples/balloon_framework.cpp
Lines 548-550 (patched)
<https://reviews.apache.org/r/61112/#comment257557>

    Can we use `CopyFrom` from `RepeatedPtrField` here?


- Alexander Rukletsov


On July 31, 2017, 1:01 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61112/
> -----------------------------------------------------------
> 
> (Updated July 31, 2017, 1:01 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Alexander Rojas.
> 
> 
> Bugs: MESOS-7814
>     https://issues.apache.org/jira/browse/MESOS-7814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allows to set URIs that will be fetched before running the executor.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp b8c8e387bd8592bc1d27ff62fa9fd5397ad71fb9 
> 
> 
> Diff: https://reviews.apache.org/r/61112/diff/2/
> 
> 
> Testing
> -------
> 
> $ make check
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message