mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60057: Made explicit that we dispatch to a process manager.
Date Mon, 31 Jul 2017 12:59:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60057/
-----------------------------------------------------------

(Updated July 31, 2017, 2:58 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Rebased.


Repository: mesos


Description
-------

This member function of 'ProcessManager' was capturing a 'this'
pointer when dispatching to itself, but did not properly use 'defer'
or 'dispatch'. While this pattern is usually suspect, it was safe here
as we can be sure that the process manager lives long enough to safely
invoke the created callback.

This patch removes the capture of 'this' and instead explicitly
references the 'static process_manager' in the created callback to
signal that we rely on external invariants.


Diffs (updated)
-----

  3rdparty/libprocess/src/process.cpp 44c3531538691dd9600b9169a83f4fd504f4f089 


Diff: https://reviews.apache.org/r/60057/diff/2/

Changes: https://reviews.apache.org/r/60057/diff/1-2/


Testing
-------

* `make check` (Fedora 25 clang-trunk w/ optimizations)


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message