mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60793: Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.
Date Sun, 30 Jul 2017 15:35:43 GMT


> On July 28, 2017, 8:41 a.m., Avinash sridharan wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp
> > Lines 1226 (patched)
> > <https://reviews.apache.org/r/60793/diff/3/?file=1782045#file1782045line1226>
> >
> >     Similar to the `DockerContainerizer` can we add a test for the flags themselves
to check that we don't allow setting DNS for HOST mode? Also, would be great to test the matching
algorithm we use to setup the DNS when we have multiple DNS entries.
> 
> Qian Zhang wrote:
>     I added a test `https://reviews.apache.org/r/61219/` for the wildcard match.

And I added a test https://reviews.apache.org/r/61245/ for the flag validation.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60793/#review181630
-----------------------------------------------------------


On July 25, 2017, 2:08 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60793/
> -----------------------------------------------------------
> 
> (Updated July 25, 2017, 2:08 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-7709
>     https://issues.apache.org/jira/browse/MESOS-7709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp ae0980bd671849fcd3e19941b33c7d3b09fdae7c

> 
> 
> Diff: https://reviews.apache.org/r/60793/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message