mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60761: Added a test `DockerContainerizerTest.ROOT_DOCKER_DefaultDNS`.
Date Sun, 30 Jul 2017 15:33:22 GMT


> On July 28, 2017, 8:35 a.m., Avinash sridharan wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4357 (patched)
> > <https://reviews.apache.org/r/60761/diff/3/?file=1782044#file1782044line4357>
> >
> >     Can we have a test for checking validation error on setting up the HOST MODE?
> 
> Qian Zhang wrote:
>     Did you mean adding a test to test the validation code in the lambda that we added
in `src/slave/flags.cpp` for the `--default_container_dns` flag? If so, then I think `docker_containerizer_tests.cpp`
may not be a good place for such test because `docker_containerizer_tests.cpp` should contain
the end-to-end tests, but for testing the validation code we do not even need to start the
agent. Maybe just add a test in `flags_tests.cpp`? And in another hand, for the other agent
flags which has the validation code in lambda, it seems there is no related test for them,
so do we really need such test for testing the validation code of `--default_container_dns`?
>     
>     BTW, I was thinking to add a test for wildcard match of Docker user-defined network,
but the problem is we can not assume any user-defined networks in the test env, but there
must be a bridge network, so currently I only have the test for the bridge network.
> 
> Avinash sridharan wrote:
>     Agreed !! if we can add the flag validation tests for the flags tests that should
be good enough.  Wildcard match test for BRIDGE mode is good enough I think.

I added a test https://reviews.apache.org/r/61219/ for the flag validation.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60761/#review181628
-----------------------------------------------------------


On July 25, 2017, 2:07 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60761/
> -----------------------------------------------------------
> 
> (Updated July 25, 2017, 2:07 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-7709
>     https://issues.apache.org/jira/browse/MESOS-7709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `DockerContainerizerTest.ROOT_DOCKER_DefaultDNS`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 1e85a79f812399270575ea4a64db10e72f40e648

> 
> 
> Diff: https://reviews.apache.org/r/60761/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message