mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61033: Added missing metrics to tests.
Date Fri, 28 Jul 2017 14:12:49 GMT


> On July 25, 2017, 10:12 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp
> > Line 1364 (original), 1365 (patched)
> > <https://reviews.apache.org/r/61033/diff/1/?file=1780702#file1780702line1365>
> >
> >     I see that you sneaked in a style fix here. Please avoid when possible.

I felt creating a separate review for this style fix is not justified in this case. However,
this is a matter of taste. Will file a separate review.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61033/#review181396
-----------------------------------------------------------


On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61033/
> -----------------------------------------------------------
> 
> (Updated July 21, 2017, 2:32 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166 
>   src/tests/slave_tests.cpp e1cc96dbb279aea998b99779ee1b55e96fee4e41 
> 
> 
> Diff: https://reviews.apache.org/r/61033/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/61034/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message