mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61032: Fixed slaves_unreachable metric.
Date Fri, 28 Jul 2017 14:10:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/
-----------------------------------------------------------

(Updated July 28, 2017, 2:10 p.m.)


Review request for mesos, Armand Grillet and Vinod Kone.


Repository: mesos


Description
-------

While a gauge for slaves_unreachable was created in master metrics,
it was not added to the metrics actor and hence was not tracked by
the metrics subsystem.


Diffs
-----

  src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f 


Diff: https://reviews.apache.org/r/61032/diff/1/


Testing (updated)
-------

Augemnted an appropriate test with a check for this metric in https://reviews.apache.org/r/61033/

See https://reviews.apache.org/r/61034/


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message