mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 61097: Added gRPC support in libprocess.
Date Fri, 28 Jul 2017 00:49:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61097/
-----------------------------------------------------------

(Updated July 28, 2017, 12:49 a.m.)


Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu.


Changes
-------

`Runtime::wait()` now returns a `Future` that waits for joining the looper thread. `Runtime::Data`
will now waits for its process to terminate during destruction.


Bugs: MESOS-7810
    https://issues.apache.org/jira/browse/MESOS-7810


Repository: mesos


Description
-------

A gRPC client can use `process::grpc::call(...)` to send an asynchronous
gRPC call and get a future for the response. The client needs to set up
two data structures: a `Channel` which represents a connection to a gRPC
server, and a `ClientRuntime` which maintains a `CompletionQueue` that
keeps track of all pending asynchronous gRPC calls, and spawns a thread
waiting for any response from the `CompletionQueue`. All gRPC calls
using the same `ClientRuntime` would share the same thread.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/grpc.hpp PRE-CREATION 
  3rdparty/libprocess/src/grpc.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/61097/diff/4/

Changes: https://reviews.apache.org/r/61097/diff/3-4/


Testing
-------

N/A


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message