mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 61075: Set container DNS with `--default_container_dns` in DockerContainerizer.
Date Fri, 28 Jul 2017 00:28:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61075/#review181626
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/slave/containerizer/docker.cpp
Lines 1333-1339 (patched)
<https://reviews.apache.org/r/61075/#comment257251>

    Some edits to the comment:
    We need to pass `flags.default_container_dns` only when the agent is not running in a
Docker container. This is to handle the case of launching a custom executor in a Docker container.
If the agent is running in a Docker container (i.e., `flags.docker_mesos_image.isSome() ==
true`), that is the case of launching `mesos-docker-executor` in a Docker container with the
Docker image `flags.docker_mesos_image`. In that case we already set `flags.default_container_dns`
in the method `dockerFlags()`.


- Avinash sridharan


On July 24, 2017, 8 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61075/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 8 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-7709
>     https://issues.apache.org/jira/browse/MESOS-7709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set container DNS with `--default_container_dns` in DockerContainerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 2fe92272d7ac6d916371c55affe24598255f10eb 
> 
> 
> Diff: https://reviews.apache.org/r/61075/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message