mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 60931: Added test cases for framework streaming events.
Date Thu, 27 Jul 2017 17:30:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60931/#review181586
-----------------------------------------------------------


Fix it, then Ship it!




Just some minor nits to fix.


src/tests/api_tests.cpp
Lines 1977 (patched)
<https://reviews.apache.org/r/60931/#comment257170>

    s/, as a result, the/. The



src/tests/api_tests.cpp
Lines 1982-1986 (patched)
<https://reviews.apache.org/r/60931/#comment257176>

    Move this before L2007 to be close to where its used.



src/tests/api_tests.cpp
Lines 1984 (patched)
<https://reviews.apache.org/r/60931/#comment257175>

    s/to be a/to a



src/tests/api_tests.cpp
Lines 1986 (patched)
<https://reviews.apache.org/r/60931/#comment257169>

    Can we just use `Weeks(2)` here instead of the magic number



src/tests/api_tests.cpp
Lines 2082 (patched)
<https://reviews.apache.org/r/60931/#comment257173>

    s/As a result, the/The


- Anand Mazumdar


On July 18, 2017, 12:29 a.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60931/
> -----------------------------------------------------------
> 
> (Updated July 18, 2017, 12:29 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-6101
>     https://issues.apache.org/jira/browse/MESOS-6101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for 'FRAMEWORK_ADDED', 'FRAMEWORK_UPDATED' and
> 'FRAMEWORK_REMOVED' events in v1 operator API.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 
> 
> 
> Diff: https://reviews.apache.org/r/60931/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message