mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <>
Subject Re: Review Request 60524: Stout: Made the `Duration` operators handle int overflows explicitly.
Date Wed, 26 Jul 2017 23:31:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 26, 2017, 11:31 p.m.)

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.


Reordered the chain.

We haven't reached consensus on this patch yet, it is likely that I'll end up discarding it.

Bugs: MESOS-7661

Repository: mesos


Made the `Duration` arithmetic operators return `Duration::max()` if the
operation would result in an integer overflow, and `Duration::min()` if
it would result in an underflow.

Diffs (updated)

  3rdparty/stout/include/stout/duration.hpp b0cd77b833f6fbf752b4db820fd43b87e1d1e476 
  3rdparty/stout/tests/duration_tests.cpp 59b08f14849a8db31f11fbd0b2e1248c99afd9dd 




Added new Stout tests and confirmed that the Mesos test suite still passes.


Gastón Kleiman

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message