mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 60525: Fixed the default filter used by the allocator.
Date Wed, 26 Jul 2017 23:30:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/
-----------------------------------------------------------

(Updated July 26, 2017, 11:30 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.


Changes
-------

I had some offline discussions with Greg, BenM, and Vinod. We agreed to cap the filter duration
to at most 365 days.


Bugs: MESOS-7660
    https://issues.apache.org/jira/browse/MESOS-7660


Repository: mesos


Description (updated)
-------

If a framework accepts/refuses an offer using a very long filter, the
`HierarchicalAllocator` will use the default filter instead. Meaning
that it will filter the resources for only 5 seconds. This can happen
when a framework sets `Filter::refuse_seconds` to a number of seconds
larger than what fits in `Duration`.

This patch makes the hierarchical allocator cap the filter duration to
at most 365 days.


Diffs (updated)
-----

  include/mesos/mesos.proto 41e42b4996235cbee26f580f4a7aa2daed166b7f 
  include/mesos/v1/mesos.proto 9de282f85b8d0ba91fa3de85acd5d0f4082a47d8 
  src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035 


Diff: https://reviews.apache.org/r/60525/diff/5/

Changes: https://reviews.apache.org/r/60525/diff/4-5/


Testing
-------

`make check`


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message