mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 60996: Adds documentation for LIBPROCESS_SSL_ECDH_CURVE environment variable.
Date Wed, 26 Jul 2017 23:08:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60996/#review181500
-----------------------------------------------------------



Nit: AFAIK we try to write our commit messages in simple past.


docs/ssl.md
Lines 78 (patched)
<https://reviews.apache.org/r/60996/#comment257117>

    s/Valid values depends on OpenSSL version used/Valid values depend on the OpenSSL version
used./



docs/ssl.md
Lines 81 (patched)
<https://reviews.apache.org/r/60996/#comment257118>

    There was only one empty line before, do we need two?


- Gastón Kleiman


On July 21, 2017, 9:30 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60996/
> -----------------------------------------------------------
> 
> (Updated July 21, 2017, 9:30 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Till Toenshoff.
> 
> 
> Bugs: MESOS-7792
>     https://issues.apache.org/jira/browse/MESOS-7792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds the adequate documentation entry for the new
> `LIBPROCESS_SSL_ECDH_CURVE` environment variable, which allow the
> configuration of ECDHE key exchange while establishing TLS sessions.
> 
> 
> Diffs
> -----
> 
>   docs/ssl.md 811390f366c97b6d61cf9b3f188e3c399abb46cd 
> 
> 
> Diff: https://reviews.apache.org/r/60996/diff/2/
> 
> 
> Testing
> -------
> 
> non functional change.
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message