mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 61122: Fixed the host volume relative host path ownership.
Date Wed, 26 Jul 2017 18:07:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61122/#review181457
-----------------------------------------------------------


Fix it, then Ship it!




LGTM!


src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 438-440 (patched)
<https://reviews.apache.org/r/61122/#comment257036>

    This can be shortened:
    ```c++
    return ErrnoError("Failed to stat '" + containerConfig.directory() + "'");
    ```



src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Line 487 (original), 502 (patched)
<https://reviews.apache.org/r/61122/#comment257055>

    Do we call this a host volume as well? We're creating it in the container sandbox.


- Ilya Pronin


On July 26, 2017, 7:41 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61122/
> -----------------------------------------------------------
> 
> (Updated July 26, 2017, 7:41 a.m.)
> 
> 
> Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Stephan Erb, Vinod Kone,
and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5187
>     https://issues.apache.org/jira/browse/MESOS-5187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This bugfix addresses the issue from MESOS-5178. Basically, the
> host volume ownership was not set correctly. This issue can be
> exposed if a framework user is non-root while the agent
> process runs as root. Then, the non-root user does not have
> permissions to write to this volume.
> 
> The correct solution should be giving permissions to corresponding
> users by leveraging supplementary groups. But we can still
> introduce a workaround in this patch by changing the ownership
> of this host volume to its sandbox's ownership.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp bf35b7f00d6e80672ffc27cfc3f3a2fd8de69a99

> 
> 
> Diff: https://reviews.apache.org/r/61122/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message