mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 61121: Added regression test for sandbox_path volume ownership issue.
Date Wed, 26 Jul 2017 16:45:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61121/#review181464
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp
Lines 152 (patched)
<https://reviews.apache.org/r/61121/#comment257068>

    s/whlie/while/



src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp
Lines 187 (patched)
<https://reviews.apache.org/r/61121/#comment257069>

    Maybe simplify this (here and above):
    ```
    ASSERT_SOME(os::chown("nobody", directory.get()));
    ```


- James Peach


On July 25, 2017, 11:15 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61121/
> -----------------------------------------------------------
> 
> (Updated July 25, 2017, 11:15 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Ilya Pronin, Jie Yu, James Peach, Vinod Kone, and
Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7830
>     https://issues.apache.org/jira/browse/MESOS-7830
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added regression test for sandbox_path volume ownership issue.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 3228b9a7df0fcb7973b210a1d0c17a18869c73d4

> 
> 
> Diff: https://reviews.apache.org/r/61121/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Verified that this test failed if we don't have the bugfix patch.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message