mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61112: Added flag executor_extra_uris to balloon framework.
Date Wed, 26 Jul 2017 13:29:17 GMT


> On July 25, 2017, 7:08 p.m., Till Toenshoff wrote:
> > src/examples/balloon_framework.cpp
> > Lines 120-124 (patched)
> > <https://reviews.apache.org/r/61112/diff/1/?file=1782174#file1782174line120>
> >
> >     I would suggest to use a different approach here -- instead of allowing multiple
URIs to be used for the executor artefact, lets simply go for using archives in those cases.
> >     
> >     Now the issue preventing us to do so here is https://github.com/apache/mesos/blob/cd3380c4e9521b4b26f9030658816eee7a4b89a1/src/examples/balloon_framework.cpp#L493
> >     
> >     Hence my suggestion is to add a new flag called e.g. `executor_executable` which
can be used if we want the fetcher to make non archive downloads `chmod` into `+X`. Whenever
that flag is not set, we can now allow archive downloads and achieve what we want without
having to;
> >     - trigger multiple downloads
> >     - accept depending libraries to be `chmod` into `+X` which wont trigger failures
but still is nasty

Another approach would be to delegate URI specification to the user. A similar approach can
be seen in e.g. [1]. This way we will allow for both scenarios: multiple URIs and a single
archive URI. The only disadvantage I see here is overcomplicating API for a fairly straightforward
framework. Having said that, it seems to me a fair price, given we've already seen requests
for specifying a command and an extra library.

[1] https://github.com/apache/mesos/blob/95fe8b367a94da6da0a580026519bf07a4f65ec7/src/cli/execute.cpp#L104


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61112/#review181366
-----------------------------------------------------------


On July 25, 2017, 3:48 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61112/
> -----------------------------------------------------------
> 
> (Updated July 25, 2017, 3:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Alexander Rojas.
> 
> 
> Bugs: MESOS-7814
>     https://issues.apache.org/jira/browse/MESOS-7814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows to set URIs that will be fetched and executed before
> running the executor.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp b8c8e387bd8592bc1d27ff62fa9fd5397ad71fb9 
> 
> 
> Diff: https://reviews.apache.org/r/61112/diff/1/
> 
> 
> Testing
> -------
> 
> $ make check
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message