mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 60770: Added validation functions for resource provider calls.
Date Wed, 26 Jul 2017 10:48:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60770/
-----------------------------------------------------------

(Updated July 26, 2017, 12:48 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Used explicit namespaces in `devolve` to avoid lookup failures when using precompiled headers
due to the newly introduced `mesos::internal::resource_provider` namespace.


Bugs: MESOS-7780
    https://issues.apache.org/jira/browse/MESOS-7780


Repository: mesos


Description
-------

Added validation functions for resource provider calls.


Diffs (updated)
-----

  src/CMakeLists.txt 51b67428f823454665db695ba70a0dc896a7595c 
  src/Makefile.am 8b91716432fb2f6210c12ed7edb312f49e57aa4c 
  src/internal/devolve.hpp 214fcefe07950590ba021c1e0b3aaa3e64231f81 
  src/internal/devolve.cpp 79c668ff86bb3b1fddc48bcd978f9d4fc026a415 
  src/resource_provider/validation.hpp PRE-CREATION 
  src/resource_provider/validation.cpp PRE-CREATION 
  src/tests/CMakeLists.txt f5fe5a6785e2d230707396cc42d9f824f2539dba 
  src/tests/resource_provider_validation_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/60770/diff/5/

Changes: https://reviews.apache.org/r/60770/diff/4-5/


Testing
-------

make check


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message