mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 61067: More optimizations for creating a MessageEvent.
Date Wed, 26 Jul 2017 04:31:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61067/#review181431
-----------------------------------------------------------



The encode and send changes look good, but I'm perplexed by the overloads on MessageEvent
construction and transport.


3rdparty/libprocess/include/process/event.hpp
Lines 95-109 (patched)
<https://reviews.apache.org/r/61067/#comment257004>

    It seems unfortunate to have to overload MessageEvent to take the Message constructor
arguments, what was the optimization here? Avoiding an extra move?



3rdparty/libprocess/src/process.cpp
Lines 798-803 (patched)
<https://reviews.apache.org/r/61067/#comment257005>

    Ditto here, what was this optimizing? Eliminating one move or something more?


- Benjamin Mahler


On July 24, 2017, 1:49 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61067/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 1:49 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7798
>     https://issues.apache.org/jira/browse/MESOS-7798
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> More optimizations for creating a MessageEvent.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp a0ec05380066e1065af2d9da3c920c8a786b6f06

>   3rdparty/libprocess/include/process/process.hpp d40179f874754e00b58f271c401650138dc7d01c

>   3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c 
> 
> 
> Diff: https://reviews.apache.org/r/61067/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message