mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 60991: Changed Device::path to optional and introduced Device::Number.
Date Wed, 26 Jul 2017 01:01:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60991/
-----------------------------------------------------------

(Updated July 25, 2017, 6:01 p.m.)


Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhongbo Tian.


Repository: mesos


Description
-------

A device in cgroup can be represented as either a path or a major:minor
number. Need to change the `required` Device::path to `optional` to
add Number in the device protobuf.


Diffs (updated)
-----

  include/mesos/mesos.proto 8f8079bd7c2de4e8b2f8f9a56e2731b77b8e1575 
  include/mesos/v1/mesos.proto 720f307f8d738b0787e7c47be7ee15be38b2c0d0 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp ddf2a4d661001a3a5832c21504420223ca60a753



Diff: https://reviews.apache.org/r/60991/diff/2/

Changes: https://reviews.apache.org/r/60991/diff/1-2/


Testing
-------

make


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message