mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 61124: Push metric history entries with their timestamp.
Date Tue, 25 Jul 2017 23:26:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61124/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.


Bugs: MESOS-6918
    https://issues.apache.org/jira/browse/MESOS-6918


Repository: mesos


Description
-------

In the Timer metric, we already have a current timestamp when
we push the sample into the history buffer. Added an optional
timestamp to Metric::push() so that we can avoid unnecessary
overhead of calling Clock::now() in the common case of Timer
metrics.


Diffs
-----

  3rdparty/libprocess/include/process/metrics/metric.hpp 21f162d5b7d9e56dc3289d65b6d86deb4c2fa721

  3rdparty/libprocess/include/process/metrics/timer.hpp 0a9c0227c457c6c81a59f65f901a5464ee00983d



Diff: https://reviews.apache.org/r/61124/diff/1/


Testing
-------

make check (Fedora 25)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message