mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 61031: Removed almost identical master and slave metrics tests.
Date Tue, 25 Jul 2017 22:02:56 GMT


> On July 25, 2017, 10:02 p.m., Vinod Kone wrote:
> > src/tests/metrics_tests.cpp
> > Lines 103-146 (original)
> > <https://reviews.apache.org/r/61031/diff/1/?file=1780698#file1780698line103>
> >
> >     Hmm. there are lot more metrics that are deleted here than the ones that are
present in master_tests.cpp and slave_tests.cpp. Not sure if these represent all the metrics
exposed in the API, but it would be nice to have tests that verify all the current metrics
so that devs can updated those tests when adding new metrics.

oops. didn't mean to give a shipit.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61031/#review181390
-----------------------------------------------------------


On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61031/
> -----------------------------------------------------------
> 
> (Updated July 21, 2017, 2:32 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166 
>   src/tests/metrics_tests.cpp a4d0e3128c661b9ca5c63994cc3b9e498cce3af7 
>   src/tests/slave_tests.cpp e1cc96dbb279aea998b99779ee1b55e96fee4e41 
> 
> 
> Diff: https://reviews.apache.org/r/61031/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/61034/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message