mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 61111: Extracted strings into constants in balloon framework.
Date Tue, 25 Jul 2017 19:22:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61111/#review181368
-----------------------------------------------------------




src/examples/balloon_framework.cpp
Line 296 (original), 300 (patched)
<https://reviews.apache.org/r/61111/#comment256907>

    We are `using std::string` already, so you can drop the namespace reference here and everywhere
else for the strings.



src/examples/balloon_framework.cpp
Line 303 (original), 307 (patched)
<https://reviews.apache.org/r/61111/#comment256906>

    Strictly speaking this line does not need any wrapping, however given that you wrapped
the others now, I would suggest to do the same with this one just to make it appear less noisy
if that makes sense.



src/examples/balloon_framework.cpp
Lines 485-486 (original), 492-493 (patched)
<https://reviews.apache.org/r/61111/#comment256908>

    Do you really need to wrap here?
    
    In any case, we commonly prefer (if possible) wrapping at the assignment instead of the
parameters when both are present.
    
    ```
    {
      // Find this executable's directory to locate executor.
      if (flags.executor_command.isSome()) {
        command =
          flags.executor_command.get();
      } else if (flags.build_dir.isSome()) {
        command =
          path::join(flags.build_dir.get(), "src", EXECUTOR_BINARY);
      } else {
        command =
          path::join(os::realpath(Path(argv[0]).dirname()).get(), EXECUTOR_BINARY);
      }
    }
    ```


- Till Toenshoff


On July 25, 2017, 3:47 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61111/
> -----------------------------------------------------------
> 
> (Updated July 25, 2017, 3:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Alexander Rojas.
> 
> 
> Bugs: MESOS-7814
>     https://issues.apache.org/jira/browse/MESOS-7814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp b8c8e387bd8592bc1d27ff62fa9fd5397ad71fb9 
> 
> 
> Diff: https://reviews.apache.org/r/61111/diff/1/
> 
> 
> Testing
> -------
> 
> $ make check
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message