mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Downes <ian.dow...@gmail.com>
Subject Re: Review Request 60203: Introduce HTB class.
Date Mon, 24 Jul 2017 18:36:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60203/
-----------------------------------------------------------

(Updated July 24, 2017, 11:36 a.m.)


Review request for mesos, Ilya Pronin, Jie Yu, Reza Motamedi, Santhosh Kumar Shanmugham, and
Cong Wang.


Changes
-------

Fix libnl call to set rbuffer, not cbuffer. Documentation is incorrect/misleading. The correct
buffer to set for sending at ceil rate is the rbuffer, not cbuffer.


Repository: mesos


Description
-------

Based heavily on Cong Wang's original review 45605.

Introduce support for HTB class and expose configuration.


Diffs (updated)
-----

  src/linux/routing/queueing/class.hpp PRE-CREATION 
  src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 
  src/linux/routing/queueing/htb.cpp 464120214b75e2e422c8ea6a57c5654ba77d669f 
  src/linux/routing/queueing/internal.hpp 9fe522ee017c86af8c7b2e518cd0957af08750e4 


Diff: https://reviews.apache.org/r/60203/diff/3/

Changes: https://reviews.apache.org/r/60203/diff/2-3/


Testing
-------

make check


Thanks,

Ian Downes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message