mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 60500: Introduced `--default_container_dns` agent flag.
Date Mon, 24 Jul 2017 17:40:32 GMT


> On July 23, 2017, 3:22 p.m., Avinash sridharan wrote:
> > src/messages/flags.proto
> > Lines 69 (patched)
> > <https://reviews.apache.org/r/60500/diff/4/?file=1781100#file1781100line69>
> >
> >     Qian, sorry, should have pointed this out earlier. I think we decided that for
Docker we can support HOST mode as well? So we can remove this comment.
> 
> Qian Zhang wrote:
>     I remember that we decided to support BRIDGE mode for Docker, but not support HOST
mode for both CNI and Docker so that they can have a consistent behavior regarding HOST mode.
Can you please double confirm with Jie?

Ah ok!! I am fine with not supporting HOST mode for docker. The use-case isn't that strong.
Probably the confusion arose on my part because your patches already did support HOST mode
for Docker so though we were planning to keep that support. Lets drop this in that case and
explicitly not support HOST mode for docker.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60500/#review181181
-----------------------------------------------------------


On July 24, 2017, 1:39 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60500/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 1:39 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-7709
>     https://issues.apache.org/jira/browse/MESOS-7709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced `--default_container_dns` agent flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md a06ac82e7b908601b9ba97011931276e6292102d 
>   src/messages/flags.hpp 70ad58c33067a0b058deafdcc4ffc5f554b6ca72 
>   src/messages/flags.proto e87075f19714739b93d9f4aa33ea8686a1bb5613 
>   src/slave/flags.hpp bf9adf03847a113306c1df2d71e839b90ada7dd3 
>   src/slave/flags.cpp a4c1a0c62af5506bbeb1d26d2fd9ca0ba11d8ad7 
>   src/slave/main.cpp a4a8ced6825ece1b25003824d987ff83fb799ad7 
> 
> 
> Diff: https://reviews.apache.org/r/60500/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message