mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60771: Implemented the 'SUBSCRIBE' call in the resource provider manager.
Date Mon, 24 Jul 2017 15:14:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60771/#review181218
-----------------------------------------------------------




src/resource_provider/manager.cpp
Lines 224-231 (patched)
<https://reviews.apache.org/r/60771/#comment256704>

    Like discussed offline, let's this pull into the `UPDATE` case for now, so that e.g.,
a `Call` with just `type == UNKNOWN` triggers a `NotImplemented`.



src/tests/resource_provider_http_api_tests.cpp
Line 64 (original), 75 (patched)
<https://reviews.apache.org/r/60771/#comment256702>

    I'd suggest we split the testing into two parts. As a unit test we could first test the
RP manager w/o involving any agents or master (e.g., by directly `POST`ing a request to `ResourceProviderManager::api`);
having a unit test should make sure we do not entable the RP manager with the agent. As a
second test we should fix the existing `AgentEndpoint` test to test the now existing data
flow from the agent endpoint to the RP manager.


- Benjamin Bannier


On July 24, 2017, 3:24 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60771/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 3:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7780
>     https://issues.apache.org/jira/browse/MESOS-7780
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using HTTP, resource providers are expected to subscribe to the resource
> provider manager. The resource provider manager will assign a unique ID
> to subscribed resource providers and use events to communicate with
> them.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp a9bf258a0896bd519b99a689a0bfab64d665172f 
>   src/tests/resource_provider_http_api_tests.cpp 46a3f37ba046201e9d79e8ba037da2cb37f5c31f

> 
> 
> Diff: https://reviews.apache.org/r/60771/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message