mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61032: Fixed slaves_unreachable metric.
Date Mon, 24 Jul 2017 13:39:53 GMT


> On July 22, 2017, 10:47 a.m., Armand Grillet wrote:
> > Regarding the summary: is this a fix? This looks like the addition of one metric
and there is no bug linked to the review request (except [MESOS-7747](https://issues.apache.org/jira/browse/MESOS-7747)
at the beginning of the chain but it is of type _Improvement_).

It is a fix, because before the metric was not actually used. For this kind of (minor) bugs,
we don't necessarily create a ticket (but we may). Since there are no existing issues mentioning
this bug, I have decided not to create one to avoid extra work and JIRA pollution.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61032/#review181173
-----------------------------------------------------------


On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61032/
> -----------------------------------------------------------
> 
> (Updated July 21, 2017, 2:32 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/metrics.cpp 646041d53642d6c25c3ea735bd9c87784374084f 
> 
> 
> Diff: https://reviews.apache.org/r/61032/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/61034/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message