mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 60770: Added validation functions for resource provider calls.
Date Mon, 24 Jul 2017 13:11:15 GMT


> On July 24, 2017, 11:53 a.m., Benjamin Bannier wrote:
> > src/resource_provider/validation.cpp
> > Lines 39-40 (patched)
> > <https://reviews.apache.org/r/60770/diff/1/?file=1774137#file1774137line39>
> >
> >     Any reason we cannot reject an `UNKNOWN` `type` here? Is there any value to
keep these calls around for later processing?
> >     
> >     Also, let's wrap this case in `{}` for consistency.

I'd argue that a call with `UNKNOWN` type is intrisically valid. Of course, in the context
we're using it, a call shouldn't be of `UNKNOWN` type, but that's validated elsewhere.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60770/#review181198
-----------------------------------------------------------


On July 24, 2017, 2:05 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60770/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7780
>     https://issues.apache.org/jira/browse/MESOS-7780
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation functions for resource provider calls.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 51b67428f823454665db695ba70a0dc896a7595c 
>   src/Makefile.am 8b91716432fb2f6210c12ed7edb312f49e57aa4c 
>   src/resource_provider/validation.hpp PRE-CREATION 
>   src/resource_provider/validation.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60770/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message