mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 60719: Add test infrastructure for src/python/lib/mesos.
Date Sun, 23 Jul 2017 23:19:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60719/#review181184
-----------------------------------------------------------


Fix it, then Ship it!




I left some comments, but will make the changes myself and commit without another iteration.
As part of this I am also adding `tox` to the `cli_new` `pip-requirements.txt` file.


src/python/.gitignore
Lines 2-4 (patched)
<https://reviews.apache.org/r/60719/#comment256676>

    I will pull this into a spearate commit when I commit this.



src/python/lib/tests/test_mesos.py
Lines 18 (patched)
<https://reviews.apache.org/r/60719/#comment256675>

    Misspelled. I will fix this myself as I commit this.


- Kevin Klues


On July 20, 2017, 6:45 p.m., Eric Chung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60719/
> -----------------------------------------------------------
> 
> (Updated July 20, 2017, 6:45 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Part of MESOS-7310, this patch adds the test infrastructure necessary
> for reliably running unit tests for the mesos package located under
> src/python/lib.
> 
> setup.py is added under src/python/lib to both define the Python package.
> tox.ini is added under the same dir to enable automated unit tests via the command `tox`,
> which run tests via pytest.
> 
> Review: https://reviews.apache.org/r/60719/
> 
> 
> Diffs
> -----
> 
>   src/python/.gitignore 0d20b6487c61e7d1bde93acf4a14b7a89083a16d 
>   src/python/lib/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/python/lib/requirements-test.in PRE-CREATION 
>   src/python/lib/requirements.in PRE-CREATION 
>   src/python/lib/setup.py PRE-CREATION 
>   src/python/lib/tests/__init__.py PRE-CREATION 
>   src/python/lib/tests/test_mesos.py PRE-CREATION 
>   src/python/lib/tox.ini PRE-CREATION 
>   support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 
> 
> 
> Diff: https://reviews.apache.org/r/60719/diff/9/
> 
> 
> Testing
> -------
> 
> 1. install tox
> 2. cd src/python/lib
> 3. tox
> 
> 
> Thanks,
> 
> Eric Chung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message