mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.
Date Fri, 21 Jul 2017 06:14:12 GMT


> On July 21, 2017, 9:43 a.m., Qian Zhang wrote:
> > include/mesos/mesos.proto
> > Line 2843 (original), 2922 (patched)
> > <https://reviews.apache.org/r/60932/diff/2-3/?file=1780157#file1780157line2922>
> >
> >     Why is `value` an optional field? I think there have to a value for any possible
semantics, right?
> 
> Gilbert Song wrote:
>     The same, I don't think an `optional` field hurts here and it makes it more flexible.
Let's chat tomorrow.

Sure, let's chat on it. And can we have an expert on this area (BenM or Jie) to provide some
comments?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60932/#review181087
-----------------------------------------------------------


On July 21, 2017, 7:57 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60932/
> -----------------------------------------------------------
> 
> (Updated July 21, 2017, 7:57 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-6162
>     https://issues.apache.org/jira/browse/MESOS-6162
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only statistics information for blkio in protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8f8079bd7c2de4e8b2f8f9a56e2731b77b8e1575 
>   include/mesos/v1/mesos.proto 720f307f8d738b0787e7c47be7ee15be38b2c0d0 
> 
> 
> Diff: https://reviews.apache.org/r/60932/diff/3/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message