mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.
Date Thu, 20 Jul 2017 08:52:32 GMT


> On July 20, 2017, 4:27 p.m., Qian Zhang wrote:
> > include/mesos/v1/mesos.proto
> > Lines 2815 (patched)
> > <https://reviews.apache.org/r/60932/diff/2/?file=1780158#file1780158line2815>
> >
> >     Why do we need this? I see `Entry.op` is a required field rather than an optional
field, so why do we need `UNKNOWN` for a required field?
> 
> Gilbert Song wrote:
>     We will use `UNKNOWN` in all protobuf enums:
>     https://issues.apache.org/jira/browse/MESOS-4997

Yeah, I saw that. But that is for backwards compatibility, and the solution mentioned in that
ticket is `use optional enum fields and include an UNKNOWN value as the first entry in the
enum`, but in this patch, the enum field `Entry.op` is required.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60932/#review181023
-----------------------------------------------------------


On July 20, 2017, 8:17 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60932/
> -----------------------------------------------------------
> 
> (Updated July 20, 2017, 8:17 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-6162
>     https://issues.apache.org/jira/browse/MESOS-6162
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only statistics information for blkio in protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8 
>   include/mesos/v1/mesos.proto 5e92e5d86023ad6edd94303fbde964bf403abf02 
> 
> 
> Diff: https://reviews.apache.org/r/60932/diff/2/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message