mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Review Request 60991: Changed Device::path to optional and introduced Device::Number.
Date Thu, 20 Jul 2017 00:16:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60991/
-----------------------------------------------------------

Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhongbo Tian.


Repository: mesos


Description
-------

A device in cgroup can be represented as either a path or a major:minor
number. Need to change the `required` Device::path to `optional` to
add Number in the device protobuf.


Diffs
-----

  include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8 
  include/mesos/v1/mesos.proto 5e92e5d86023ad6edd94303fbde964bf403abf02 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp ddf2a4d661001a3a5832c21504420223ca60a753



Diff: https://reviews.apache.org/r/60991/diff/1/


Testing
-------

make


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message