mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.
Date Thu, 20 Jul 2017 00:08:29 GMT


> On July 18, 2017, 6:31 a.m., Qian Zhang wrote:
> > include/mesos/mesos.proto
> > Lines 2955 (patched)
> > <https://reviews.apache.org/r/60932/diff/1/?file=1778071#file1778071line2955>
> >
> >     If we introduce a field like this, does that mean we will fill it in `BlkioSubsystem::status()`
since `CgroupInfo` is part of `ContainerStatus`?
> 
> Gilbert Song wrote:
>     I would suggest let's remove this field and leave a TODO here, which will be addressed
when we introduce the `prepare` and `status` functions. What do you think?
> 
> Qian Zhang wrote:
>     So for `prepare()`, we are going to use `CgroupInfo.blkio` to do the blkio control?
If so, then I am OK with it. And for `status()`, what will be the difference between it and
`usage()`? Are they gonna return same statistic about blkio?

I decide to remove all other fields except `statistics`. Let's introduce them later when necessary.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60932/#review180794
-----------------------------------------------------------


On July 18, 2017, 2:39 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60932/
> -----------------------------------------------------------
> 
> (Updated July 18, 2017, 2:39 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-6162
>     https://issues.apache.org/jira/browse/MESOS-6162
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added protobuf scheme for blkio subsystem in CgroupInfo.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8 
> 
> 
> Diff: https://reviews.apache.org/r/60932/diff/1/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message