mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.
Date Thu, 20 Jul 2017 00:08:21 GMT


> On July 19, 2017, 12:02 p.m., Jie Yu wrote:
> > include/mesos/mesos.proto
> > Lines 1298 (patched)
> > <https://reviews.apache.org/r/60932/diff/1/?file=1778071#file1778071line1298>
> >
> >     Can we re-use the existing `Device` in mesos.proto. I think we should make `path`
optional.
> >     ```
> >     message Device {
> >       message Number {
> >         required uint64 major;
> >         required uint64 minor;
> >       }
> >       
> >       optional string path;
> >       optional Number number;
> >     }
> >     ```

make sense. I make this change on a separate patch.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60932/#review180958
-----------------------------------------------------------


On July 18, 2017, 2:39 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60932/
> -----------------------------------------------------------
> 
> (Updated July 18, 2017, 2:39 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-6162
>     https://issues.apache.org/jira/browse/MESOS-6162
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added protobuf scheme for blkio subsystem in CgroupInfo.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8 
> 
> 
> Diff: https://reviews.apache.org/r/60932/diff/1/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message