mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Review Request 60984: Set the `LIBPROCESS_IP` env variable before starting the fetcher.
Date Wed, 19 Jul 2017 21:03:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60984/
-----------------------------------------------------------

Review request for mesos, Avinash sridharan, Jie Yu, and Till Toenshoff.


Bugs: MESOS-7796
    https://issues.apache.org/jira/browse/MESOS-7796


Repository: mesos


Description
-------

This patch updates the containerizer to manually set the `LIBPROCESS_IP`
environment variable to `127.0.0.1` when launching the fetcher POSIX
process.

This environment variable is needed so that libprocess can be
initialized without depending on an external environment.


Diffs
-----

  src/slave/containerizer/fetcher.cpp 6a664e0657a19d27afac98fd5298d6a18aabe43f 


Diff: https://reviews.apache.org/r/60984/diff/1/


Testing
-------

`make check`

I also started tasks with URIs using DC/OS + Marathon on AWS clusters on which it is not possible
to resolve localhost. The tasks failed without this patch, but they succeeded after having
applied it.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message