mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 60959: Removed the optional time window from metrics::Counter.
Date Wed, 19 Jul 2017 09:03:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60959/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.


Bugs: MESOS-6918
    https://issues.apache.org/jira/browse/MESOS-6918


Repository: mesos


Description
-------

Although it makes sense for a monitoring system show Counters as a time
series, adding a time window to a metrics::Counter generates percentile
statistics, which don't make any sense for counters. Remove the time
window argument so that Counters don't ever get a TimeSeries.


Diffs
-----

  3rdparty/libprocess/include/process/metrics/counter.hpp 15aeeb5710636d4e11b862faee50fd6ea4d1cb07



Diff: https://reviews.apache.org/r/60959/diff/1/


Testing
-------

make check


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message