mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 60960: Added an enum to track Metric semantics.
Date Wed, 19 Jul 2017 09:02:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60960/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Kevin Klues, and Jiang Yan Xu.


Bugs: MESOS-6918
    https://issues.apache.org/jira/browse/MESOS-6918


Repository: mesos


Description
-------

Added a Semantics enumeration to to process::Metrics to track the
semantics content of a Metric. This is needed for Prometheus metrics
output where we need to know what Prometheus data type to attribute
to each Metric.


Diffs
-----

  3rdparty/libprocess/include/process/metrics/counter.hpp 15aeeb5710636d4e11b862faee50fd6ea4d1cb07

  3rdparty/libprocess/include/process/metrics/gauge.hpp 474f8e80b0128ae8d742a022733019351710ef48

  3rdparty/libprocess/include/process/metrics/metric.hpp 21f162d5b7d9e56dc3289d65b6d86deb4c2fa721

  3rdparty/libprocess/include/process/metrics/timer.hpp 0a9c0227c457c6c81a59f65f901a5464ee00983d



Diff: https://reviews.apache.org/r/60960/diff/1/


Testing
-------

make check


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message