mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 60956: Refactored fetcher cache metrics.
Date Wed, 19 Jul 2017 03:04:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60956/
-----------------------------------------------------------

Review request for mesos, Joseph Wu and Jiang Yan Xu.


Bugs: MESOS-7782
    https://issues.apache.org/jira/browse/MESOS-7782


Repository: mesos


Description
-------

Refactored fetcher cache metrics to be more consistent with how
metrics are handled in other processes. Added an inner "Metrics"
class to hold the metrics, and renamed them to snake_case following
the published metrics names.


Diffs
-----

  src/slave/containerizer/fetcher.cpp 6a664e0657a19d27afac98fd5298d6a18aabe43f 
  src/slave/containerizer/fetcher_process.hpp 3ed7dc9db5b64b72881249767c0356a3bc5370e7 


Diff: https://reviews.apache.org/r/60956/diff/1/


Testing
-------

make check (Fedora 26)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message