mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 60953: Updated libprocess for the new 3rdparty moodycamel/concurrentqueue.
Date Wed, 19 Jul 2017 00:16:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60953/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Benjamin Hindman.


Repository: mesos


Description
-------

This is a header only library that provides a lock-free concurrent
queue which we can leverage in libprocess to improve performance.

The update to the CMake build will be added separately from this
change, note that this does not break the CMake build, since it
is not used yet. The plan is to have inclusion of concurrentqueue.h
be guarded by a configure flag to begin with, which means that it
will not break the CMake build, it will however prevent CMake
users from choosing to use the concurrent queue until the CMake
integration is complete.


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 8a2adf2e95ce0d63a32f562bf6af1685abc17ab5 
  3rdparty/libprocess/Makefile.am d2b2ed21b912247a8d926e67f49e2cdef7ea11f6 
  3rdparty/libprocess/configure.ac cec01908db73418a549cd79d1d701a19dd623821 


Diff: https://reviews.apache.org/r/60953/diff/1/


Testing
-------

make tests


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message