mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 60825: Performance optimizations for message passing.
Date Tue, 18 Jul 2017 22:29:46 GMT


> On July 15, 2017, 2:08 a.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/src/process.cpp
> > Line 560 (original), 561-562 (patched)
> > <https://reviews.apache.org/r/60825/diff/1/?file=1776832#file1776832line561>
> >
> >     This seems to suggest there will be a comment about it in the run_queue.hpp
header but there isn't?

Added a comment, thanks!


> On July 15, 2017, 2:08 a.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/src/run_queue.hpp
> > Lines 73 (patched)
> > <https://reviews.apache.org/r/60825/diff/1/?file=1776833#file1776833line73>
> >
> >     const?

Agreed.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60825/#review180626
-----------------------------------------------------------


On July 18, 2017, 10:22 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60825/
> -----------------------------------------------------------
> 
> (Updated July 18, 2017, 10:22 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7798
>     https://issues.apache.org/jira/browse/MESOS-7798
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Optimizations include:
> 
> * Factored out run queue and introduced lock free implementation. This
>   also required adding the concept of an `epoch` to support proper
>   settling and refactoring the increments/decrements of `running` to
>   make it easier to reason about.
> 
> * Replaced the use of a condition variable (the `Gate`) with a
>   semaphore.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c2190b40b748c19a7db1605f69449cc59f95d1cb 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 2c46d43ed8418f128f12fad10151700611e81b1e

>   3rdparty/libprocess/configure.ac cec01908db73418a549cd79d1d701a19dd623821 
>   3rdparty/libprocess/src/CMakeLists.txt 670dc1510c0ca656abd7f7dfc781f799e54303ec 
>   3rdparty/libprocess/src/concurrentqueue.hpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 7ce6d2b13baa68906e091a95c0dd58ee1ca2bc7d 
>   3rdparty/libprocess/src/run_queue.hpp PRE-CREATION 
>   3rdparty/libprocess/src/semaphore.hpp PRE-CREATION 
>   configure.ac 4d7c4a4679e5c624ee750226d542e0d8c228507a 
> 
> 
> Diff: https://reviews.apache.org/r/60825/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message