> On July 18, 2017, 5:54 p.m., Alexander Rojas wrote:
> > src/common/http.hpp
> > Lines 205 (patched)
> > <https://reviews.apache.org/r/60820/diff/7/?file=1776508#file1776508line205>
> >
> > Why are these default constructors necesary?
It used to be necessary because we were trying to get rid of 'Owned', and using the default
constructor in the /slave/containers endpoint. Now it has been replaced by templated IDAcceptor.
- Quinn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180833
-----------------------------------------------------------
On July 14, 2017, 12:10 a.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 12:10 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit contains the class definitions for SlaveIDAcceptor and
> ContainerIDAcceptor, which are used to filter the
> '/master/frameworks', '/master/slaves' and '/slave/containers'
> endpoints.
>
>
> Diffs
> -----
>
> src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e
> src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309
>
>
> Diff: https://reviews.apache.org/r/60820/diff/7/
>
>
> Testing
> -------
>
> make check -j48
>
>
> Thanks,
>
> Quinn Leng
>
>
|