mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 60915: Enabled filtering of reservations in the agent.
Date Tue, 18 Jul 2017 12:41:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60915/#review180806
-----------------------------------------------------------



Looks good to me but it lacks an unit test.

- Alexander Rojas


On July 18, 2017, 11 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60915/
> -----------------------------------------------------------
> 
> (Updated July 18, 2017, 11 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Benjamin Mahler, and haosdent huang.
> 
> 
> Bugs: MESOS-6441
>     https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds support of the `VIEW_ROLE` ACL to the results generated by the
> `/state` endpoint in the agent for fields `reserved_resources_full`,
> `reserved_resources` and `reserved_resources_allocated`.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 60640e5dbf6c3f8c709351e77ca89f287cf12fc3 
> 
> 
> Diff: https://reviews.apache.org/r/60915/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message