mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 60791: Add fetcher cache space usage metrics.
Date Tue, 18 Jul 2017 02:13:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60791/
-----------------------------------------------------------

(Updated July 18, 2017, 2:13 a.m.)


Review request for mesos, Joseph Wu and Jiang Yan Xu.


Bugs: MESOS-7782
    https://issues.apache.org/jira/browse/MESOS-7782


Repository: mesos


Description (updated)
-------

Add fetcher metrics to track the (constant) size of the cache size
and the (varying) amount of cache space use. The cache size is
published as `containerizer/fetcher/cache_size_total` and the used
space is `containerizer/fetcher/cache_size_used`. Both of these
metrics are in MB to be consistent with other disk space metrics.
We manually convert to fractional MB so that small amounts of space
usage don't get truncated away.


Diffs (updated)
-----

  docs/monitoring.md 38b8093ef683b5de65cbfa5330a6bbd1c9e10f12 
  src/slave/containerizer/fetcher.cpp 6a664e0657a19d27afac98fd5298d6a18aabe43f 
  src/slave/containerizer/fetcher_process.hpp 3ed7dc9db5b64b72881249767c0356a3bc5370e7 
  src/tests/fetcher_cache_tests.cpp 1c654e511d2079de746ac97a2c2718e1b926768e 


Diff: https://reviews.apache.org/r/60791/diff/3/

Changes: https://reviews.apache.org/r/60791/diff/2-3/


Testing
-------

make check (Fedora 26).


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message