mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 60822: Added filtering to /slaves, /slave/containers and /frameworks endpoints.
Date Mon, 17 Jul 2017 22:46:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60822/#review180750
-----------------------------------------------------------




src/master/http.cpp
Line 529 (original), 537-538 (patched)
<https://reviews.apache.org/r/60822/#comment255961>

    `&` should go next to the type:
    
    ```
      const Owned<AuthorizationAcceptor>& authorizeRole_;
      const SlaveIDAcceptor& selectSlaveId_;
    ```



src/master/http.cpp
Line 2467 (original), 2482 (patched)
<https://reviews.apache.org/r/60822/#comment255964>

    Indent this two more spaces.



src/master/http.cpp
Line 2793 (original), 2798 (patched)
<https://reviews.apache.org/r/60822/#comment255963>

    Indent this two more spaces.



src/slave/http.cpp
Lines 2109 (patched)
<https://reviews.apache.org/r/60822/#comment255970>

    Can we get rid of the `Owned` here?



src/slave/http.cpp
Lines 2131 (patched)
<https://reviews.apache.org/r/60822/#comment255975>

    Since `AuthorizationAcceptor::accept()` returns a `bool`, the `Try` is not necessary here.
You could combine this check with the other two in the `if` statement above.


- Greg Mann


On July 14, 2017, 12:13 a.m., Quinn Leng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60822/
> -----------------------------------------------------------
> 
> (Updated July 14, 2017, 12:13 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7630
>     https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added query parameter support for the '/master/slaves',
> '/master/frameworks' and '/slave/containers' endpoints.
> 
> This allows slaves, frameworks and containers to be queried
> by ID.
> 
> If no ID is specified, all records are returned, consistent
> with current behavior.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 948aa118101b6ce03410c9e0c945b6ca16668ca2 
>   src/slave/http.hpp ad412d4e2fde13a7afa3563c611ef50b11829cac 
>   src/slave/http.cpp 3070b3b06a9d9e75b9d5afb255098e63a1056ec2 
> 
> 
> Diff: https://reviews.apache.org/r/60822/diff/4/
> 
> 
> Testing
> -------
> 
> Passed 'make check -j48'
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message