mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 60901: Use a consistent preprocessor check for ENABLE_PORT_MAPPING_ISOLATOR.
Date Sun, 16 Jul 2017 23:42:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60901/
-----------------------------------------------------------

Review request for mesos and Qian Zhang.


Bugs: MESOS-7675
    https://issues.apache.org/jira/browse/MESOS-7675


Repository: mesos


Description
-------

There's no need to also check for Windows when testing the
ENABLE_PORT_MAPPING_ISOLATOR feature macro, because
ENABLE_PORT_MAPPING_ISOLATOR requires libnl3, which is a
Linux-specific features.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539



Diff: https://reviews.apache.org/r/60901/diff/1/


Testing
-------

make check (Frdora 26).


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message